Great job and thx for sharing your web component @AaronSterling
Event maybe not triggered?
I tested it, worked fine except the
rated event which was never emitted. Don’t know if I did something wrong? I did publish my test blank app where I tried your component in the following repo, if you would like to have a look https://github.com/peterpeterparker/ionic-stars
Note: before testing, after
npm install, you would need to modify
copy.config.js…I didn’t create a separate local copy, I have just modified the one under
Maybe a missing step in the readme?
Furthermore, if I’m not missing it, I think that maybe a third step is missing in your
readme in section
Ionic Angular Setup. The include of the lib (thru
import 'star-rating-web-component...'; in
app.module.ts or in index.html itself or ?, I’m curious to know how you do it) isn’t documented https://github.com/Aaron-Sterling/star-rating-web-component/blob/master/docs/ionic-angular-setup.md
Not related to your component but to the tech, Android 8.1 bug?
Finally, not related to your component but to the tech itself, I become to be worried about the integration on Android 8.1. With you component and a blank Ionic project I faced the exact same issue as I already did with my app and two different other components respectively Android 8.1 just don’t want to load the component.
Still don’t know if I do something wrong in the way I include/load the component or if it’s really a bug, but like I said, that “worries me a bit” ([Stencil] Error on Nexus 5X / Android 8.1 only)
Again thx for you component, furthermore to being a cool component which could be included in any modern frontend framework, it helps me to understand a bit more how it works