[Ionic-v4] Need your input on navigation code!

Hi all,

I’ve been trying to wrap my head around how to implement navigation in an Ionic 4 app and after some research I created a tiny skeleton project that uses Tabs, Routing, NavController, ModalController and ion-nav within a modal page!

I would very much like to get your input to see if I got it all right, both in code and best practices. I’m especially unsure about where and how to best define routing.

Please check it out and comment all you can!!! :slight_smile: