Ionic doctor check Issue (CORS?)

jQrgen · 2017-10-25 07:37:07 UTC

Just trying out the new ionic doctor command, and i got this error when checking my app’s “health”.

In the message it says “not authorized” because of a missing rule. Where is the config file for this rule?

(Deleted ID from IMG)

Sujan12 · 2017-10-25 10:20:25 UTC

This would be better placed as an issue at https://github.com/ionic-team/ionic-cli/issues or via the support channels: http://ionicframework.com/support#support

jQrgen · 2017-10-25 12:26:45 UTC

Okay

But what I am really wondering is how the ionic doctor tool works.

The tool has no documentation in the cli docs nor can i find any guides online.

Thanks

Sujan12 · 2017-10-25 12:44:57 UTC

No idea. It was added a few versions ago and released “officially” with the last release of the CLI.

Code seems to live here:

github.com

ionic-team/ionic-cli/blob/master/packages/@ionic/cli-utils/src/lib/doctor/index.ts

import chalk from 'chalk';

import { IonicEnvironment } from '../../definitions';
import { isExitCodeException } from '../../guards';
import { Ailment, Ailments, AutomaticallyTreatableAilment } from './ailments';

const ERROR_AILMENT_SKIPPED = 'AILMENT_SKIPPED';
const ERROR_AILMENT_IGNORED = 'AILMENT_IGNORED';

export class AilmentRegistry {
  protected _ailments: Ailment[] = [];

  register(ailment: Ailment) {
    this._ailments.push(ailment);
  }

  get ailments(): Ailment[] {
    return this._ailments;
  }

This file has been truncated. show original

github.com

ionic-team/ionic-cli/blob/master/packages/@ionic/cli-utils/src/lib/doctor/ailments.ts

import * as path from 'path';

import chalk from 'chalk';
import * as semver from 'semver';

import { IonicEnvironment } from '../../definitions';
// import { isCordovaPackageJson } from '../../guards';
import { App } from '../app';
import { BACKEND_PRO } from '../backends';
import { getIonicRemote, isRepoInitialized } from '../git';
import { fsReadDir, fsReadFile, pathExists } from '@ionic/cli-framework/utils/fs';
import { readPackageJsonFile } from '@ionic/cli-framework/utils/npm';
import { pkgLatestVersion, pkgManagerArgs } from '../utils/npm';
import { Project as IonicAngularProject } from '../project/ionic-angular';
import { getPlatforms } from '../cordova/project';
import { ConfigXml } from '../cordova/config';

export interface TreatmentStep {
  name: string;
}

This file has been truncated. show original

Sujan12 · 2017-10-25 12:50:35 UTC

Ah, and post your ionic info output please - so we know which version of the CLI is causing this problem for you.

Sujan12 · 2017-10-25 12:55:51 UTC

Ah, ionic doctor list might list all the problems it is looking for if I understood the code correctly.

Sujan12 · 2017-10-25 13:04:14 UTC

Ah, the website should contain docs on this by the way:

Seems someone at Ionic forgot to deploy these changes.

jQrgen · 2017-10-25 13:13:14 UTC

Helens-iMac:flare-ionic2 Flare$ ionic info

cli packages: (/Users/Flare/.nvm/versions/node/v8.7.0/lib/node_modules)

    @ionic/cli-utils  : 1.15.0
    ionic (Ionic CLI) : 3.15.0

global packages:

    cordova (Cordova CLI) : 7.1.0 

local packages:

    @ionic/app-scripts : 3.0.0
    Cordova Platforms  : ios 4.5.2
    Ionic Framework    : ionic-angular 3.7.1

System:

    ios-deploy : 1.9.2 
    Node       : v8.7.0
    npm        : 5.5.1 
    OS         : macOS High Sierra
    Xcode      : Xcode 9.0.1 Build version 9A1004 

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : pro

Sujan12 · 2017-10-25 13:42:49 UTC

Are you logged in to Ionic Pro on the command line?

jQrgen · 2017-10-25 17:15:25 UTC

Yup

Helens-iMac:flare-ionic2 Flare$ ionic login
[WARN] You are already logged in as …@…com! Prompting for new
credentials.

Sujan12 · 2017-10-25 17:31:20 UTC

Is 6b...4d your correct app id?

jQrgen · 2017-10-25 17:39:03 UTC

Yeah, there is it. I don’t have access to that ionic pro app anymore because I had to change owner for unrelated reasons.

Thanks for the help. It would be nice if you delete the app ID from the thread for security reasons.

Also i saw you published the docs, nice

Sujan12 · 2017-10-25 17:50:44 UTC

Interesting - maybe doctor should catch this in a better way? Seems like the perfect thing it could/should check and handle with a good error message.
I think you should create an issue at https://github.com/ionic-team/ionic-cli/issues about this.

I didn’t do a thing, but someone from Ionic might be reading here

PS: censored the app id.