Has-header class still in use?


#1

Hi,

I read in the Release Notes that the has-header class was deprecated, so I removed it from all my views. However, on my Side Menu, the menu list now slides up behind the Header, so I have put it back in.

Just checking if it is deprecated or not (ie. should I be using it or will it be removed completely when out of beta so I should look for a different solution?)


#2

Hmmm - I think I understand how it is working now: I had to use has-headers when I had my Header bar declared like this:

    <header class="bar bar-header bar-dark">
        <h1 class="title">My Menu</h1>
    </header>

but I can remove it (and it is cleaner) when I changed it to:

    <ion-header-bar class="bar-dark">
        <h1 class="title">My Menu</h1>
    </ion-header-bar>

#3

It doesn’t just make it look cleaner when you use the ion-* directives. All the directives that add styles for you are also generally adding a bunch of javascript to enable other features too. For example you can add the item class to any element and make it look like an ion-item but if you use ion-item you can add the swipe to edit/remove directives easily.


#4

Thanks for the tip - I think I copied my code from the Ionic documentation directly, however I will double check and convert it to the non-attribute style.