How to share data between controllers : Whats wrong with this code?

ionic-v1
7

Thanks for your help.

Can you please take a look on my this question.

I am stuck with this problem since last 2 days